Project

General

Profile

Issue #552

move pki tool to ipsecdir

Added by Pavel Šimerda over 6 years ago. Updated over 6 years ago.

Status:
Feedback
Priority:
Normal
Category:
-
Affected version:
5.1.2
Resolution:

Description

Hi,

to avoid clashes with other packages, we're moving the pki executable into the ipsecdir (which we set to /usr/libexec/strongwan) on Fedora. We would be happy to upstream the patch if possible. Also, I found out that src/ipsec/_ipsec.in is overly complicated. It might be best to just set $PATH at the beginning, prefer strongswan locations and then call the commands directly without absolute path.

Cheers,

Pavel

strongswan-5.1.2-libexec.patch (1.22 KB) strongswan-5.1.2-libexec.patch Patch used in Fedora to avoid conflicts Pavel Šimerda, 24.03.2014 12:36
strongswan-5.1.2-libexec.patch (2.03 KB) strongswan-5.1.2-libexec.patch Patch used in Fedora to avoid conflicts (v2) Pavel Šimerda, 24.03.2014 12:46

History

#2 Updated by Tobias Brunner over 6 years ago

  • Status changed from New to Feedback
  • Assignee set to Tobias Brunner

to avoid clashes with other packages, we're moving the pki executable into the ipsecdir (which we set to /usr/libexec/strongwan) on Fedora.

Why don't you just ./configure with --bindir=/usr/libexec/strongswan? pki is currently the only program that gets installed in bin, ipsec and charon-cmd are installed in sbin.

Also, I found out that src/ipsec/_ipsec.in is overly complicated. It might be best to just set $PATH at the beginning, prefer strongswan locations and then call the commands directly without absolute path.

Yeah, I suppose setting PATH and still calling the programs with an absolute path is a bit redundant (could be that this has historical reasons).

#3 Updated by Pavel Šimerda over 6 years ago

Tobias Brunner wrote:

to avoid clashes with other packages, we're moving the pki executable into the ipsecdir (which we set to /usr/libexec/strongwan) on Fedora.

Why don't you just ./configure with --bindir=/usr/libexec/strongswan? pki is currently the only program that gets installed in bin, ipsec and charon-cmd are installed in sbin.

I didn't realize that. It would be a solution as well as long as all other binaries are in sbin. If the current strongswan 5.1.2 packages work as expected, I'm going to leave the current solution as is. But I'll be happy to switch to whatever is recommended for 5.1.3 when it's out.

Also, I found out that src/ipsec/_ipsec.in is overly complicated. It might be best to just set $PATH at the beginning, prefer strongswan locations and then call the commands directly without absolute path.

Yeah, I suppose setting PATH and still calling the programs with an absolute path is a bit redundant (could be that this has historical reasons).

And there's like ten distinct exported environment variables to handle that, most (all?) of which probably don't need to be exported at all. All of them are filled in using sed. I guess it calls for a bit of simlification. I guess you have other important tasks in strongswan, so I could send patches with some minor cleanups if you're interested.

#4 Updated by Pavel Šimerda over 6 years ago

Any update?

Also available in: Atom PDF