Project

General

Profile

Bug #1113

OpenSSL plugin: issue with OpenSSL compiled with OPENSSL_NO_DEPRECATED

Added by Dirk Feytons about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Category:
build
Target version:
Start date:
15.09.2015
Due date:
Estimated time:
Affected version:
5.3.3
Resolution:
Fixed

Description

When OpenSSL is compiled with the OPENSSL_NO_DEPRECATED option a number of historical mishaps in the API have been corrected. One of them is that headers like openssl/dh.h or openssl/rsa.h no longer include openssl/bn.h. I've found that code in the libstrongswan OpenSSL plugin uses BN_* functions without having included openssl/bn.h explicitly, instead relying on it being included implicitly by other OpenSSL headers. This causes compilation warnings and runtime problems when OpenSSL was compiled with this OPENSSL_NO_DEPRECATED option.
Patch to fix this is attached.

explicit-openssl-includes.patch (1.32 KB) explicit-openssl-includes.patch Dirk Feytons, 15.09.2015 11:25

Associated revisions

Revision 5f18e2c3 (diff)
Added by Tobias Brunner about 5 years ago

openssl: Explicitly include openssl/bn.h

If OpenSSL is compiled with OPENSSL_NO_DEPRECATED some of the headers
we include don't include openssl/bn.h anymore. Therefore, we have to
explicitly include it ourselves where we use BN_* functions.

Fixes #1113.

History

#1 Updated by Tobias Brunner about 5 years ago

  • Tracker changed from Issue to Bug
  • Category set to build
  • Status changed from New to Closed
  • Assignee set to Tobias Brunner
  • Target version set to 5.3.4
  • Resolution set to Fixed

Applied to master, thanks!

Also available in: Atom PDF