Project

General

Profile

Bug #781

Setting libstrongswan.dh_exponent_ansi_x9_42 is not working

Added by Martin Schiller over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
libstrongswan
Target version:
Start date:
05.12.2014
Due date:
Estimated time:
Affected version:
5.2.1
Resolution:
Fixed

Description

Setting libstrongswan.dh_exponent_ansi_x9_42 is not working.

After some debugging, I've found out that the configured value will always be ignored and the default value (TRUE) will be used.
Changing "lib->settings->get_int()" to "lib->settings->get_bool()" in src/libstrongswan/crypto/diffie_hellman.c will fix it.

Associated revisions

Revision 0a5b60db (diff)
Added by Martin Willi over 5 years ago

diffie-hellman: Handle dh_exponent_ansi_x9_42 as a boolean setting

While it was always documented as boolean setting, the option is currently
handled as integer value, for which yes/no values do not work. Instead the
default of TRUE is used for a no value.

The option has been moved a lot during the last years, and in some locations
was handled as bool, in some as integer. In the latest codebase it
congruently used integer, which is actually not what is documented and used
in testing.

Fixes #781.

History

#1 Updated by Martin Willi over 5 years ago

  • Tracker changed from Issue to Bug
  • Status changed from New to Closed
  • Assignee set to Martin Willi
  • Target version set to 5.2.2
  • Resolution set to Fixed

Hi,

Thanks for your bug report. I've addressed this issue with the referenced commit, merged to master.

Seems this type has been used in some locations ever since, and the wrong type has made it into the latest version.

As a work-around, you may also set it to 0 or 1 to have any effect.

Regards
Martin

Also available in: Atom PDF