Project

General

Profile

Bug #690

Build broken with --enable-monolithic

Added by Emeric Poupon over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
build
Target version:
Start date:
27.08.2014
Due date:
Estimated time:
Affected version:
5.2.0
Resolution:
Fixed

Description

Hello,

When building strongswan with the following configuration:

./configure --enable-monolithic --disable-ikev1 --enable-kernel-pfkey --enable-kernel-pfroute --disable-kernel-netlink --disable-kernel-libipsec --enable-socket-default --disable-socket-dynamic --enable-ha --enable-openssl --enable-addrblock --enable-cmd --enable-load-tester --disable-aes --disable-cmac --disable-des --disable-fips-prf --disable-md5 --disable-hmac --disable-rc2 --disable-random --disable-sha1 --disable-sha2 --disable-xcbc --disable-dnskey --disable-pgp --disable-sshkey --disable-revocation --disable-scripts --disable-scepclient --disable-gmp --disable-sql --disable-sqlite --disable-mysql --prefix=/usr/local --mandir=/usr/local/man --infodir=/usr/local/info/

I get this bug:

...
libtool: link: gcc -g -O2 -Wall -Wno-format -Wno-format-security -Wno-pointer-sign -include /usr/home/emericp/svn/trunk/tmp/amd64/contrib/usr/home/emericp/svn/trunk/contrib/strongswan/work/strongswan-5.2.0/config.h -o .libs/charon charon.o -L/usr/local/lib ../../src/libstrongswan/.libs/libstrongswan.so ../../src/libhydra/.libs/libhydra.so ../../src/libcharon/.libs/libcharon.so /usr/home/emericp/svn/trunk/tmp/amd64/contrib/usr/home/emericp/svn/trunk/contrib/strongswan/work/strongswan-5.2.0/src/libhydra/.libs/libhydra.so /usr/home/emericp/svn/trunk/tmp/amd64/contrib/usr/home/emericp/svn/trunk/contrib/strongswan/work/strongswan-5.2.0/src/libstrongswan/.libs/libstrongswan.so -lexecinfo -lcrypto -lm -lpthread -Wl,-rpath -Wl,/usr/Firewall/lib
../../src/libcharon/.libs/libcharon.so: undefined reference to `adopt_children_job_create'

Th build is fine if monolithic option is disabled.

It seems the files processing/jobs/adopt_children_job.c processing/jobs/adopt_children_job.h do not have to be compiled only if USE_IKEV1 is defined. (it solved the problem to compile it whatever the IKE version is)

Regards,

Associated revisions

Revision e1c7e1bc (diff)
Added by Martin Willi over 6 years ago

ha: Don't adopt IKEv1 children when building without IKEv1 support

The adopt_children_job_create() function is not available when IKEv1 support
is disabled. Fixes uncommon builds using --enable-ha --disable-ikev1.

Fixes #690.

History

#1 Updated by Martin Willi over 6 years ago

  • Status changed from New to Closed
  • Assignee set to Martin Willi
  • Target version set to 5.2.1
  • Resolution set to Fixed

Hi Emeric,

--enable-ha [...] --disable-ikev1

The HA plugin didn't use the adopt_children_job_create() function conditionally, which is only available when using IKEv1. Hence that configuration failed to build.

I've fixed the issue in master with the referenced commit.

Regards
Martin

Also available in: Atom PDF