Project

General

Profile

Bug #3448

network manager GUI too tall

Added by Harald Dunkel 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
networkmanager (charon-nm)
Target version:
Start date:
Due date:
Estimated time:
Affected version:
5.8.4
Resolution:
Fixed

Description

Hi folks,

there is a problem with the new network manager applet 1.5.1: Its too tall to fit on my screen (1600x900, which is not that uncommon for a laptop). [OK] and [Cancel] buttons are below the bottom edge of my screen. Desktop is xfce4.

Setting a custom font size and reducing icon size doesn't seem to help. The font is smaller, but the general layout of the GUI has the same size.

Do you think it would be possible to move the cipher proposals to an "advanced" menu tab? Suggesting ciphers surely is.

Regards
Harri


Related issues

Has duplicate Issue #3459: nm gnome config UI too tallClosed

Associated revisions

Revision 7b15ecf8 (diff)
Added by Tobias Brunner 3 months ago

nm: Use tabs for options/proposals to save screen space

The height of the dialog increased due to the recently added additional
fields for certificate selection and identities. On some screens the
fields to configure custom proposals were not visible anymore.
Together with less spacing on the top level GtkBox this change reduces
the height by about 80 pixels.

Fixes #3448.

Revision 1ebf63b9 (diff)
Added by Tobias Brunner 3 months ago

nm: Move server port to options tab and position tabs to the left

Also shortened the title of the proposal tab. This saves some additional
screen space.

Fixes #3448.

History

#1 Updated by Harald Dunkel 3 months ago

PS: Using Gnome the [Cancel] and [Apply] buttons are at the top edge of the GUI, but now the Cipher Proposals are below the bottom edge of the screen.

#2 Updated by Tobias Brunner 3 months ago

  • Category set to networkmanager (charon-nm)
  • Status changed from New to Feedback

In the 3448-nm-height branch, I've moved the options and proposals into tabs (GtkNotebook), which reduces the height by 80 pixels. Let me know if that works for you.

#3 Updated by Harald Dunkel 3 months ago

Much better now, but the buttons are only partially visible, still. They are covered by the xfce panel at the bottom edge. If I move the GUI to the top right corner, then there is no problem. I can live with that.

Using Gnome the Apply button is at the top. The ESP cipher proposal is only partially visible. Its covered by the systray. Trying to move the window up a little bit further I managed to move the window beyond to top edge somehow, making the Apply & Cance button unavailable, as well as the window decorations. Surely a bug in Gnome. There was no way to get rid of it but brute force.

#4 Updated by Tobias Brunner 3 months ago

I guess we could save some more space by moving the server port to either a new advanced options tab, or to the existing options tab while moving the tabs also to the left (the latter doesn't help with three tabs on newer Gnome version as the height three stacked tab buttons would exceed that of their contents). I pushed another commit to the branch that does the latter.

#5 Updated by Harald Dunkel 3 months ago

I really like the new GUI. Thanx very much

Do you think it would be OK to include this patch in Debian's network-manager-strongswan package (version 1.5.1)? Or should I wait with this for version 1.5.2?

#6 Updated by Tobias Brunner 3 months ago

I really like the new GUI. Thanx very much

Cool, thanks.

Do you think it would be OK to include this patch in Debian's network-manager-strongswan package (version 1.5.1)? Or should I wait with this for version 1.5.2?

I pushed the changes to master and released 1.5.2. Note that this also includes 73b60338dc, which renames NetworkManager-strongswan.appdata.xml to NetworkManager-strongswan.metainfo.xml and installs it in /usr/share/metainfo instead of /usr/share/appdata. I guess this has to be handled somehow in the Debian package during the package upgrade.

#7 Updated by Tobias Brunner 3 months ago

  • Tracker changed from Issue to Bug
  • Status changed from Feedback to Closed
  • Assignee set to Tobias Brunner
  • Target version set to 5.9.0
  • Resolution set to Fixed

#8 Updated by Tobias Brunner 2 months ago

  • Has duplicate Issue #3459: nm gnome config UI too tall added

Also available in: Atom PDF