Project

General

Profile

Bug #1053

./configure: checking for qsort_r flavour is broken when -Wextra is added to CFLAGS

Added by Марк Коренберг over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Category:
build
Target version:
Start date:
04.08.2015
Due date:
Estimated time:
Affected version:
5.3.2
Resolution:
Fixed

Description

This happen because AC_CHECK_FUNC code for detecting qsort_r flavour is broken. It does not mark variables as being unused, so gcc issues warning (when -Wextra enabled), and due to -Werror each flavour become unusable.

Associated revisions

Revision 3103c682 (diff)
Added by Tobias Brunner over 5 years ago

configure: Explicitly disable unused parameter warnings in qsort_r test

When compiling with -Wextra (and without disabling these warnings
globally) the tests would otherwise fail due to the unused arguments in
the cmp() functions.

Fixes #1053.

History

#1 Updated by Tobias Brunner over 5 years ago

  • Tracker changed from Issue to Bug
  • Status changed from New to Feedback
  • Target version set to 5.3.3
  • % Done set to 0

While I compile with -Wextra myself, I never encountered this problem. The reason for that is, of course, that I also disable several warnings explicitly when compiling strongSwan with it, -Wno-unused-parameter is one of them (there are lots of other places in the code where that will result in a warning otherwise, and I don't really care for it), so I never noticed this flaw. I now added -Wno-unused-parameter to the CFLAGS in the test, which should fix the problem. See the referenced commit.

#2 Updated by Tobias Brunner about 5 years ago

  • Status changed from Feedback to Closed
  • Assignee set to Tobias Brunner
  • Resolution set to Fixed

Also available in: Atom PDF